OCPBUGS-63152: Fail wait-for-node-ip if primary IP(s) disappear #5350
Conversation
Under specific scenario it is possible that between nodeip-configuration.service and kubelet.service the br-ex interface loses one of its IP stacks. This is undesired because it will cause kubelet to be stuck without any clear error message. With this change we will make wait-for-node-ip.service fail in a clear way if one of the IP addresses used by kubelet are not available. The timeout 60 seconds has been selected as arbitrary. In a positive scenario the service should succeed immediately. In a negative scenario when the IP address really disappeared, 60 seconds is fair to wait. In a scenario when we are racing and handle tentative IPv6 addresses 60 seconds is enough for an address to settle and become permanent.
openshift-ci-robot
added
jira/valid-reference
|
@mkowalski: This pull request references Jira Issue OCPBUGS-63152, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mkowalski: This pull request references Jira Issue OCPBUGS-63152, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Under specific scenario it is possible that between nodeip-configuration.service and kubelet.service the br-ex interface loses one of its IP stacks. This is undesired because it will cause kubelet to be stuck without any clear error message.
With this change we will make wait-for-node-ip.service fail in a clear way if one of the IP addresses used by kubelet are not available.
The timeout 60 seconds has been selected as arbitrary. In a positive scenario the service should succeed immediately. In a negative scenario when the IP address really disappeared, 60 seconds is fair to wait. In a scenario when we are racing and handle tentative IPv6 addresses 60 seconds is enough for an address to settle and become permanent.
Fixes: OCPBUGS-63152